-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
7007: Fix parsing error for backslashes in math formulas within new flowchart shape syntax #7086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: d277426 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
on-behalf-of: @Mermaid-Chart <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7086 +/- ##
==========================================
- Coverage 3.55% 3.55% -0.01%
==========================================
Files 473 473
Lines 47481 47496 +15
Branches 730 730
==========================================
Hits 1687 1687
- Misses 45794 45809 +15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
sidharthv96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on-behalf-of: @Mermaid-Chart <[email protected]>
resolved in d277426 |


📑 Summary
This PR fixes a parsing issue where math formulas containing backslashes (
\) were incorrectly handled in the new flowchart shape syntax. The issue caused Mermaid to throw a lexical or syntax error when formulas like\frac{a}{b}orx \to ywere used inside shape definitions.Resolves #7007
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.