Skip to content

Fix waypoints #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 25, 2025
Merged

Fix waypoints #2237

merged 5 commits into from
Jun 25, 2025

Conversation

RCGV1
Copy link
Member

@RCGV1 RCGV1 commented Jun 23, 2025

The iOS app sends non-expiring waypoints as expire=0; we will now treat those as never expiring and always show them. Additionally, the Date and Time formatted strings sometimes did not display, so we now initialize them instead of using onChange.

@RCGV1
Copy link
Member Author

RCGV1 commented Jun 23, 2025

Fixes #2224

@jamesarich jamesarich requested a review from Copilot June 23, 2025 19:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates waypoint expiration logic to treat expire=0 as never expiring and always show those waypoints, and fixes date/time display in the Edit Waypoint dialog by initializing formatted strings up front.

  • Include non-expiring waypoints (expire == 0) in the live view.
  • Initialize selectedDate and selectedTime with current values instead of relying on onChange.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
app/src/main/java/com/geeksville/mesh/ui/map/components/EditWaypointDialog.kt Move initialization of selectedDate, selectedTime, and epochTime to setup with current calendar values.
app/src/main/java/com/geeksville/mesh/model/UIState.kt Extend filter to include expire == 0 as a non-expiring waypoint.
Comments suppressed due to low confidence (1)

app/src/main/java/com/geeksville/mesh/model/UIState.kt:565

  • Add or update unit tests to verify that waypoints with expire = 0 are correctly retained, and that the filtering logic still excludes expired entries.
            }

@jamesarich jamesarich merged commit 0abc6e0 into meshtastic:main Jun 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants