add JS repo as git sub module #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR integrates the external JS repository as a git submodule into the web repository to simplify further development without relying on package mocking or npm linking.
- Added a git submodule entry for the JS repository
- Points the submodule to "src/core/connection" for organized access
Comments suppressed due to low confidence (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the JS repo as a git sub module to the web repository. This allows for further development of the JS repo without having to fiddle with package mocking or npm linking.
Changes Made
git submodule add https://github.com/meshtastic./js.git src/core/connectionwhich allows you to point a specific repo and give it a "mount point" in your parent repoChecklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)