fix: move i18n languages to public folder #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR moves i18n translation files to the public directory to follow best practices and fixes issues with translations not being properly copied into the distribution. Key changes include updating paths in configuration files, adjusting import statements, and revising file path references in GitHub workflows and documentation.
Reviewed Changes
Copilot reviewed 10 out of 180 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Updated the destination path for translation files |
| src/pages/Messages.tsx | Added an extra CSS class for correct flex layout |
| src/index.tsx | Updated the import path for the i18n configuration |
| src/i18n-config.ts | Modified loadPath to reflect the new translation file location |
| src/core/hooks/useLang.ts | Adjusted import to use the new alias for i18n config |
| src/core/connection | Updated subproject commit |
| src/components/LanguageSwitcher.tsx | Updated import to use the new alias for i18n config |
| crowdin.yml | Updated source and translation file paths |
| CONTRIBUTING_I18N_DEVELOPER_GUIDE.md | Revised file reference to match the new translation location |
| .github/workflows/crowdin-upload-sources.yml | Updated file paths for monitoring JSON translation files |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danditomaso
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR follows the i18n best practices and moves all translation files into a sub dir within the public directory. All references have been updated to refer to this new location including github actions.
Related Issues
An issue occurred during our latest pre-release where translations were not available correctly copied into the distribution.
Changes Made
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)