Skip to content

Add monorepo support to project #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 26, 2025

Conversation

danditomaso
Copy link
Collaborator

Description

This pull request introduces several large scale changes to the repositry. As a result of the addition of several new applications to the web repo, we needed a way to orgnize simlar apps that will be sharing code and thus the monorepo. All files have been moved into /packages/web in a like for like migration so anything that worked previously will now live under /packages/web.

Changes Made

  • Moved all files under /packages/web
  • Created workspace root deno.json and indicated in configuration file that the web package is one module.

Checklist

  • Code follows project style guidelines
  • Documentation has been updated or added
  • Tests have been added or updated
  • All i18n translation labels have been added (read
    CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)

@Copilot Copilot AI review requested due to automatic review settings June 26, 2025 00:32
Copy link

vercel bot commented Jun 26, 2025

@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restructures the repository into a monorepo by moving the existing web app under packages/web, adding workspace configurations for Deno, updating package scripts, and adjusting the pre-commit hook.

  • Migrated all web files into packages/web
  • Introduced package-level and root-level deno.json workspace configs
  • Updated package.json scripts and dependencies, and adjusted the pre-commit hook to target the new structure

Reviewed Changes

Copilot reviewed 6 out of 458 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/web/src/components/PageComponents/Connect/Serial.tsx Removed an unused SerialPort type import
packages/web/src/components/LanguageSwitcher.tsx Adjusted dropdown width from w-64 to w-48
packages/web/package.json Added generate:routes script, updated package script, moved/updated dependencies and removed lint-staged
packages/web/deno.json Created a package-level Deno config with import aliases and TS options
deno.json Configured root workspace to include packages/web and cleared root imports
.githooks/_/pre-commit Scoped lint & format hook to packages/web
Comments suppressed due to low confidence (1)

deno.json:5

  • [nitpick] The root deno.json now has an empty imports map after moving configs to package-level; if other packages rely on import remapping, ensure this change doesn't break their imports or consider consolidating common aliases at the root.
  "imports": {},

Copy link

vercel bot commented Jun 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web-test ✅ Ready (Inspect) Visit Preview Jun 26, 2025 1:22am

@danditomaso danditomaso merged commit 1c13343 into meshtastic:main Jun 26, 2025
2 checks passed
@danditomaso danditomaso deleted the add-monorepo-support branch June 26, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant