Implement generic host #934
Draft
+2,486
−1,815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meir017
reviewed
Jan 22, 2025
libs/host/GarnetApplication.cs
Outdated
| /// </summary> | ||
| public class GarnetApplication : IHost | ||
| { | ||
| /// <summary> |
There was a problem hiding this comment.
should these be properties?
s3w3nofficial
force-pushed
the
s3w3nofficial/implement-generic-host
branch
from
9239518 to
24a075f
Compare
|
Hi @badrishc, could you please take a look at this ? There is still work to be done but i would appreciate some initial review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate GarnetServer with generic host.