Skip to content

[rush] Remove deprecated shell: true usage. #5496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iclanton wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −9
Open

[rush] Remove deprecated shell: true usage. #5496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@microsoft/rush/remove-rush-shell_2025-12-11-08-20.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@microsoft/rush",
"comment": "Remove use of the deprecated `shell: true` option in process spawn operations.",
"type": "none"
}
],
"packageName": "@microsoft/rush"
}
7 changes: 2 additions & 5 deletions libraries/rush-lib/src/scripts/install-run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,7 @@ function _resolvePackageVersion(

const spawnSyncOptions: childProcess.SpawnSyncOptions = {
cwd: rushTempFolder,
stdio: [],
shell: _isWindows()
stdio: []
};
const platformNpmPath: string = _getPlatformPath(npmPath);
const npmVersionSpawnResult: childProcess.SpawnSyncReturns<Buffer | string> = childProcess.spawnSync(
Expand Down Expand Up @@ -365,8 +364,7 @@ function _installPackage(
const result: childProcess.SpawnSyncReturns<Buffer> = childProcess.spawnSync(platformNpmPath, [command], {
stdio: 'inherit',
cwd: packageInstallFolder,
env: process.env,
shell: _isWindows()
env: process.env
});

if (result.status !== 0) {
Expand Down Expand Up @@ -466,7 +464,6 @@ export function installAndRun(
result = childProcess.spawnSync(platformBinPath, packageBinArgs, {
stdio: 'inherit',
windowsVerbatimArguments: false,
shell: _isWindows(),
cwd: process.cwd(),
env: process.env
});
Expand Down
4 changes: 0 additions & 4 deletions libraries/rush-lib/src/utilities/Utilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,11 +645,9 @@ export class Utilities {
): TCommandResult {
let shellCommand: string = process.env.comspec || 'cmd';
let commandFlags: string = '/d /s /c';
let useShell: boolean = true;
if (process.platform !== 'win32') {
shellCommand = 'sh';
commandFlags = '-c';
useShell = false;
}

const environment: IEnvironment = Utilities._createEnvironmentForRushCommand({
Expand All @@ -670,7 +668,6 @@ export class Utilities {

const spawnOptions: child_process.SpawnOptions = {
cwd: options.workingDirectory,
shell: useShell,
env: environment,
stdio
};
Expand Down Expand Up @@ -810,7 +807,6 @@ export class Utilities {
}: IExecuteCommandInternalOptions): Promise<IWaitForExitResult<string> | IWaitForExitResultWithoutOutput> {
const options: child_process.SpawnSyncOptions = {
cwd: workingDirectory,
shell: true,
stdio: stdio,
env: keepEnvironment
? environment
Expand Down
Loading