Change hook file shebang to use /usr/bin/env bash instead of /bin/bash
#5498
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update shebang line in hook file to use env bash.
lachiemurray
requested review from
D4N14L,
apostolisms,
dmichon-msft,
iclanton and
octogonz
as code owners
Contributor
Author
|
@microsoft-github-policy-service agree company="Enode" |
iclanton
approved these changes
Dec 17, 2025
common/changes/@microsoft/rush/use-env-bash_2025-12-11-20-30.json
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some OSs (for example NisOS) don't have
/bin/bashby default. Meaning that all hook scripts will currently fail to run. A more universal approach would be to use/usr/bin/env bash. It still requires bash but doesn't require it to be present in the /bin directory.Details
Might be nice for the choice of interpreter to be configurable but that would go beyond the scope of what I'm trying to solve (to get it working by default on NixOS)
How it was tested
Not explicitly
Impacted documentation
I didn't see anything relevant under: https://rushjs.io/pages/maintainer/git_hooks/