Add experimental reranker service #1401
Open
+135
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds an experimental remote reranker service and integrates it into workspace chunk search when enabled.
- Introduces IRerankerService and its implementation with a remote endpoint driven by experimentation.
- Adds enableRerank option to search options and conditional remote rerank logic before existing local rerank flow.
- Registers the new service in the VS Code extension service container.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/platform/workspaceChunkSearch/node/workspaceChunkSearchService.ts | Injects reranker service and adds conditional remote rerank branch in search flow. |
| src/platform/workspaceChunkSearch/common/workspaceChunkSearch.ts | Adds enableRerank flag to search options. |
| src/platform/workspaceChunkSearch/common/rerankerService.ts | Implements remote reranking with endpoint lookup via experimentation service. |
| src/extension/extension/vscode-node/services.ts | Registers the reranker service in the instantiation builder. |
src/platform/workspaceChunkSearch/node/workspaceChunkSearchService.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
mjbvz
approved these changes
Oct 17, 2025
| } | ||
|
|
||
| async rerank(query: string, documents: readonly FileChunkAndScore[], token: CancellationToken): Promise<readonly FileChunkAndScore[]> { | ||
| if (!documents.length || !this.isAvailable || !this._endpoint) { |
There was a problem hiding this comment.
Should we warn if you call this service and it's not available?
| }; | ||
|
|
||
| // If explicit rerank is enabled, use the remote reranker | ||
| if (options.enableRerank && this._rerankerService.isAvailable) { |
There was a problem hiding this comment.
Just checking if we really want to do this in the full workspace case too
There was a problem hiding this comment.
I'm not sure what @rebornix does in this case today. I think if you explicitly pass "enable rerank" maybe. Or maybe you shouldn't even get the "full workspace" case but be treated as if you want ranked semantic chunks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an experimental reranking endpoint to be fulfilled via ExP