Skip to content

⚡️ Speed up function _prepare_position by 6% #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function _prepare_position by 6% #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions plotly/shapeannotation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,25 @@ def _df_anno(xanchor, yanchor, x, y):


def _add_inside_to_position(pos):
if not ("inside" in pos or "outside" in pos):
# Expecting pos as set, do nothing if 'inside' or 'outside' present
if "inside" not in pos and "outside" not in pos:
pos.add("inside")
return pos


def _prepare_position(position, prepend_inside=False):
if position is None:
position = "top right"
pos_str = position
position = set(position.split(" "))
if prepend_inside:
position = _add_inside_to_position(position)
return position, pos_str
pos_str = position
pos_set = {"top", "right"}
else:
pos_str = position
if prepend_inside:
pos_set = set(pos_str.split(" "))
pos_set = _add_inside_to_position(pos_set)
else:
pos_set = set(pos_str.split(" "))
return pos_set, pos_str


def annotation_params_for_line(shape_type, shape_args, position):
Expand Down