Auto-scale PC and Game Grid Text on supported Android Versions #1162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android versions (O+) If a PC or Game's name is too long it would wrap to multiple lines in the Grid View which is not aesthetically pleasing. This change adds text autoscaling to supported autoscaling to supported Android versions and limits the line length to 1 even without supported versions.
Jasparigus
changed the title
Author
|
What is needed to get some traction on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My PC's name is "AWESOMESAUCE". Whenever I would launch Moonlight the name of my PC would show up on 2 lines.
This was slightly annoying to me so I sought out to create a fix.
With this change font sizes will now automatically scale depending on the length on text on both the PC and Game Grid Views to fit longer text. This only happens for device with the minimum Android Version (O or greater).
Lower devices will still print on one line with truncated text.
I chose an arbitrary min and max font sizes but in my testing they look decent.
I am open to adjusting these however.
Testing done on 1080p Android TV.
Before
After
Short PC name
Long PC name
Short Game name
Long Game name
