Skip to content

Fix [Release Automation] Don't try to add the Nightly group to Betas after a nightly is built #27082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

Eijebong
Copy link
Contributor

@Eijebong Eijebong commented Jun 4, 2025

💡 Description

In e528a9a we tried adding a 2 minutes wait between pushing the build to TestFlight and the addition of the nightly group to said build. That is apparently not enough time for apple to start returning that new build as the latest.

This partially reverts e528a9a and instead makes a AddNightlyGroupToTestFlightBeta workflow that we can call called on a bitrise schedule long after the nightly finishes building.

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If needed, I updated documentation and added comments to complex code
  • If needed, I added a backport comment (example @Mergifyio backport release/v120)

In e528a9a we tried adding a 2 minutes
wait between pushing the build to TestFlight and the addition of the
nightly group to said build. That is apparently not enough time for
apple to start returning that new build as the latest.

This partially reverts e528a9a and
instead makes a `AddNightlyGroupToTestFlightBeta` workflow that we can
call called on a bitrise schedule long after the nightly finishes
building.
@Eijebong Eijebong requested a review from a team as a code owner June 4, 2025 16:22
@Eijebong Eijebong requested a review from mdotb-moz June 4, 2025 16:22
@mobiletest-ci-bot
Copy link

Messages
📖 Edited 1 files
📖 Created 0 files

Generated by 🚫 Danger Swift against 3e5d591

Copy link
Contributor

This PR has been automatically marked as stale. Please leave any comment to keep this PR opened. It will be closed automatically if no further update occurs in the next 7 days. Thank you for your contributions!

@github-actions github-actions bot added the stale Stalebot use this label to stale issues and PRs label Jun 19, 2025
@Eijebong
Copy link
Contributor Author

@rvandermeulen Was this solved another way or just forgotten?

@github-actions github-actions bot removed the stale Stalebot use this label to stale issues and PRs label Jun 24, 2025
@DonalMe DonalMe merged commit ef16e79 into main Jun 24, 2025
11 checks passed
@DonalMe DonalMe deleted the borivel/remove-auto-nightly-addition branch June 24, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants