Skip to content

Bugfix FXIOS-12567 [Top Sites Visual Refresh] Top site cell background and clipping issues when using a wallpaper #27420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

Bugfix FXIOS-12567 [Top Sites Visual Refresh] Top site cell background and clipping issues when using a wallpaper #27420

merged 1 commit into from
Jun 19, 2025

Conversation

Foxbolts
Copy link
Collaborator

@Foxbolts Foxbolts commented Jun 18, 2025 •
edited
Loading

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Fixes issue with favicon backgrounds and pin icons when a wallpaper is applied

🎥 Demos

Before After
Simulator Screenshot - iPhone 16 - 2025-06-18 at 15 21 20 Simulator Screenshot - iPhone 16 - 2025-06-18 at 15 20 04

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If needed, I updated documentation and added comments to complex code
  • If needed, I added a backport comment (example @Mergifyio backport release/v120)

@Foxbolts Foxbolts requested a review from a team as a code owner June 18, 2025 19:18
@Foxbolts
Copy link
Collaborator Author

@Mergifyio backport release/v140

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 18, 2025 •
edited
Loading

backport release/v140

✅ Backports have been created

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 36.71%
📖 Edited 2 files
📖 Created 0 files

Client.app: Coverage: 35.44

File Coverage
UIView+Extension.swift 12.5% ⚠️
TopSiteCell.swift 0.0% ⚠️

CredentialProvider.appex: Coverage: 25.93

File Coverage
UIView+Extension.swift 12.5% ⚠️

Generated by 🚫 Danger Swift against 3cf8b53

@Foxbolts Foxbolts changed the title Bugfix FXIOS-12567 [Top Sites Visual Refresh] Top site celling background and clipping issues when using a wallpaper Bugfix FXIOS-12567 [Top Sites Visual Refresh] Top site cell background and clipping issues when using a wallpaper Jun 19, 2025
@Foxbolts Foxbolts merged commit 0a4a4e0 into main Jun 19, 2025
11 checks passed
@Foxbolts Foxbolts deleted the fb/FXIOS-12567_top-site-cells-wallpaper-issue branch June 19, 2025 22:46
mergify bot pushed a commit that referenced this pull request Jun 19, 2025
@Foxbolts @mergify
Bugfix FXIOS-12567 [Top Sites Visual Refresh] Top site cell backgroun…
d2343a7 
…d and clipping issues when using a wallpaper (#27420)

(cherry picked from commit 0a4a4e0)
@mergify mergify bot mentioned this pull request Jun 19, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adudenamedruby adudenamedruby adudenamedruby approved these changes

@cyndichin cyndichin Awaiting requested review from cyndichin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Foxbolts @mobiletest-ci-bot @adudenamedruby