Skip to content

FXIOS-12575 [Swift 6] Enable SWIFT_UPCOMING_FEATURE_DISABLE_OUTWARD_ACTOR_ISOLATION #27422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Cramsden
Copy link
Contributor

📜 Tickets

Jira ticket

💡 Description

Enable upcoming Swift 6 feature SWIFT_UPCOMING_FEATURE_DISABLE_OUTWARD_ACTOR_ISOLATION. There were no errors.

🎥 Demos

Before After
Demo

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If needed, I updated documentation and added comments to complex code
  • If needed, I added a backport comment (example @Mergifyio backport release/v120)

@Cramsden Cramsden requested a review from a team as a code owner June 18, 2025 19:40
@Cramsden Cramsden requested review from Foxbolts and lmarceau June 18, 2025 19:40
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Jun 18, 2025

Messages
📖 Edited 1 files
📖 Created 0 files

Generated by 🚫 Danger Swift against c5c7a6a

Copy link
Contributor

mergify bot commented Jun 18, 2025

This pull request has conflicts when rebasing. Could you fix it @Cramsden? 🙏

@ih-codes
Copy link
Collaborator

@Mergifyio rebase

Copy link
Contributor

mergify bot commented Jun 18, 2025

rebase

☑️ Nothing to do, the required conditions are not met

  • -conflict [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]
  • any of:
    • #commits-behind > 0 [📌 rebase requirement]
    • #commits > 1 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]

@ih-codes ih-codes force-pushed the cr/FXIOS-12575-enable-SWIFT_UPCOMING_FEATURE_DISABLE_OUTWARD_ACTOR_ISOLATION branch from da7e813 to c5c7a6a Compare June 18, 2025 21:54
@ih-codes
Copy link
Collaborator

FYI just force pushed to resolve the merge conflicts.

@Cramsden Cramsden merged commit e962c04 into main Jun 19, 2025
8 checks passed
@Cramsden Cramsden deleted the cr/FXIOS-12575-enable-SWIFT_UPCOMING_FEATURE_DISABLE_OUTWARD_ACTOR_ISOLATION branch June 19, 2025 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants