Skip to content

Refactor FXIOS-12585 - [Swift 6 Migration] - Turn the flag ON for Concise Magic File #27455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 25, 2025
Merged

Refactor FXIOS-12585 - [Swift 6 Migration] - Turn the flag ON for Concise Magic File #27455

merged 3 commits into from
Jun 25, 2025

Conversation

PARAIPAN9
Copy link
Collaborator

@PARAIPAN9 PARAIPAN9 commented Jun 20, 2025 •
edited
Loading

📜 Tickets

Jira ticket
Github issue

💡 Description

🎥 Demos

Before After
Demo

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If needed, I updated documentation and added comments to complex code
  • If needed, I added a backport comment (example @Mergifyio backport release/v120)

@PARAIPAN9 PARAIPAN9 requested review from a team as code owners June 20, 2025 09:19
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 35.69%
📖 Edited 70 files
📖 Created 0 files

Client.app: Coverage: 35.33

File Coverage
LoginListViewModel.swift 64.44% ✅

Generated by 🚫 Danger Swift against fec2fe1

@PARAIPAN9 PARAIPAN9 merged commit f17473a into mozilla-mobile:main Jun 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cramsden Cramsden Cramsden approved these changes

@dragosb01 dragosb01 dragosb01 approved these changes

@lmarceau lmarceau Awaiting requested review from lmarceau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PARAIPAN9 @mobiletest-ci-bot @Cramsden @dragosb01