Skip to content

Bugfix FXIOS-12617 #27494 ⁃ App crashes on siri shortcut open new tab #27496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

Bugfix FXIOS-12617 #27494 ⁃ App crashes on siri shortcut open new tab #27496

merged 1 commit into from
Jun 23, 2025

Conversation

yoanarios
Copy link
Contributor

πŸ“œ Tickets

Jira ticket
Github issue

πŸ’‘ Description

Use the async/await version of SiriShortcuts + settings logger category

πŸ“ Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If needed, I updated documentation and added comments to complex code
  • If needed, I added a backport comment (example @Mergifyio backport release/v120)

@yoanarios yoanarios requested a review from thatswinnie June 23, 2025 12:46
@yoanarios yoanarios requested a review from a team as a code owner June 23, 2025 12:46
@mobiletest-ci-bot
Copy link

Messages
πŸ“– Project coverage: 36.71%
πŸ“– Edited 3 files
πŸ“– Created 0 files

Client.app: Coverage: 35.33

File Coverage
SiriSettingsViewController.swift 10.71% ⚠️
SiriShortcuts.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 2bbe69c

@thatswinnie thatswinnie merged commit 9b9fe4e into main Jun 23, 2025
11 checks passed
@thatswinnie thatswinnie deleted the yrd/FXIOS-12617-27494-app-crashes-on-siri-shortcut-open-new-tab branch June 23, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatswinnie thatswinnie thatswinnie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoanarios @mobiletest-ci-bot @thatswinnie