Skip to content

FXIOS-12246 Fix for TopTabsViewController is init on iPhone (backport #27484) #27503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

FXIOS-12246 Fix for TopTabsViewController is init on iPhone (backport #27484) #27503

merged 1 commit into from
Jun 23, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 23, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Added a check before firing setupTopTabsViewController()

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If needed, I updated documentation and added comments to complex code
  • If needed, I added a backport comment (example @Mergifyio backport release/v120)
This is an automatic backport of pull request #27484 done by [Mergify](https://mergify.com).

@utsavDave97 @mergify
FXIOS-12246 Fix for TopTabsViewController is init on iPhone (#27484)
10d418d 
fix for TopTabsViewController is init on iPhone

(cherry picked from commit 898cad7)
@mergify mergify bot requested a review from a team as a code owner June 23, 2025 14:36
@mergify mergify bot requested review from Cramsden and removed request for a team June 23, 2025 14:36
@mergify mergify bot mentioned this pull request Jun 23, 2025
Merged
7 tasks
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 36.69%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 35.16

File Coverage
BrowserViewController.swift 21.0% ⚠️

Generated by 🚫 Danger Swift against 10d418d

@thatswinnie thatswinnie merged commit a1d99ba into release/v141 Jun 23, 2025
9 checks passed
@thatswinnie thatswinnie deleted the mergify/bp/release/v141/pr-27484 branch June 23, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatswinnie thatswinnie thatswinnie approved these changes

@Cramsden Cramsden Awaiting requested review from Cramsden Cramsden is a code owner automatically assigned from mozilla-mobile/fxios-eng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mobiletest-ci-bot @thatswinnie @utsavDave97