Skip to content

FXIOS-27064 Navigation arrows become active after a restart #27548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2025

Conversation

utsavDave97
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Fix for navigation arrows getting active after restart and home page getting appended after each launch

Before

before.mp4

After

after.mp4

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If needed, I updated documentation and added comments to complex code
  • If needed, I added a backport comment (example @Mergifyio backport release/v120)

@utsavDave97 utsavDave97 requested a review from a team as a code owner June 24, 2025 22:27
@utsavDave97 utsavDave97 requested a review from PARAIPAN9 June 24, 2025 22:27
Copy link
Collaborator

@PARAIPAN9 PARAIPAN9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest merge the two guards in one, something like:

guard tabRestoreHasFinished, selectedTab?.url?.isFxHomeUrl == false else { return }

@utsavDave97
Copy link
Contributor Author

I'd suggest merge the two guards in one, something like:

guard tabRestoreHasFinished, selectedTab?.url?.isFxHomeUrl == false else { return }

True thanks. Done 968ab75

@utsavDave97 utsavDave97 requested a review from PARAIPAN9 June 25, 2025 13:14
Copy link
Collaborator

@PARAIPAN9 PARAIPAN9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!! TYVM!! 😎

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 36.82%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 35.33

File Coverage
TabManagerImplementation.swift 53.31%

Generated by 🚫 Danger Swift against 124579f

@PARAIPAN9 PARAIPAN9 merged commit 0f83258 into mozilla-mobile:main Jun 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants