chore(syncserver): break up extractors.rs

[chenba]

Description

sync server's extractors.rs was quite large. This patch simply breaks it up. There are no type or functionality changes.

Testing

Existing tests should pass.

Issue(s)

Closes STOR-367 / #1820

[chenba]

Couldn't come up with good name for this. :-/

[taddes]

👍 I would get heart palpitations every time I opened the extractors.rs file. This really helps. Let @pjenvey take a look too, but looks great. Thanks for doing this

[pjenvey]

do we really have that many extractors? that's a lot of extractors. thanks!

[pjenvey]

We could also move these tests into their specific modules (e.g. bso_query_params) but totally fine for now.

[chenba]

move these tests into their specific modules

Oh yeah, my bad. I should've done that in the first place; that's my preference as well.

[pjenvey]

Couple nitpicks here that I won't block on:

• we're not consistent but we try to organize imports by a grouping of std/external/crate separated by a newline. rustfmt doesn't enforce this but I'll note it has an option for this grouping in nightly, "StdExternalCrate". So this crate block would go below the last import, separated by a newline like in batch_request.rs
• You could also replace crate::web::extractors:: with super:: (or more specifically super::validation:: here) -- not just because it's shorter but I think it could help avoid wildcard imports in mod.rs. Ideally mod.rs would only pub use what's exposed outside of extractors vs internal -- e.g. everything in validation.rs is internal and doesn't need pub in mod.rs. But I'm not complaining, still beats 2k lines of extractors.rs

[pjenvey]

Forgot my only actual request: could you move the contents of this module into bso_query_params.rs? As it's specific to there and doesn't have its own FromRequest

[chenba]

@pjenvey Thank you for the feedback. I think I've made all the suggested changes. They are in a separate commit: 7678e88. (I'll squash and rebase master once approved.)