Fix Postgres post_user Infinite Recursion

[chenba]

The postgres-e2e-tests job was failing in CircleCI due to a stack overflow error. The problem was that TokenserverPgDb::post_user had #[cfg(debug_assertions)] thus was not in the release build against which the integration tests were executed, resulting in an infinite recursion in the Db train impl of post_user.

Closes STOR-397 / #1869

[chenba]

@taddes Why did we have this flag here?

[taddes]

That's a conditional compilation attribute, which tells the compiler to only include the annotated code when compiling in debug mode (debug_assertions). This was for testing purposes and matched the interface for MySQL, but it looks like it might have needed to be annotated the impl Db for TokenserverPgDb . There is a mix of cases where some are annotated with #[cfg(debug_assertions)] at the interface definition at the bottom, and some when the traits are actually implemented. I don't know why it's one of the few methods in both postgres and mysql to not have that annotation. Needless to say, I'm sorry if that's the goose you've been chasing and that was seemingly enough to break the test run.

[chenba]

This was for testing purposes and matched the interface for MySQL, but it looks like it might have needed to be annotated the impl Db for TokenserverPgDb .

Why don't we want the actual impl in the release build?

[taddes]

That's a good question, this applies to a lot of them and existing ones in MySQL. Let's tag @pjenvey

[taddes]

🚀