refactor(metrics): make hostname in metrics optional #1880
+41
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenba
commented
Nov 5, 2025
syncserver/src/server/mod.rs
Outdated
| } else { | ||
| metric | ||
| } | ||
| } |
There was a problem hiding this comment.
The alternative would be a macro. I think a macro reads better and it's my preference. @pjenvey do you have a preference?
There was a problem hiding this comment.
I agree with all the lifetimes involved makes a quick macro justified.
Though I think there's potentially another less generic option since they're all (currently) gauge calls w/ u64s: a closure that does the entire gauge+send call: let send_gauge_with_maybe_hostname = |key, value| { ... } (with it capturing metrics/hostname from the outer scope so they don't need to be passed as args)
There was a problem hiding this comment.
Made the change to a closure. Thank you for the suggestion.
chenba
force-pushed
the
refactor/hostname-optional-metrics-STOR-393
branch
from
57ccbed to
6a47c67
Compare
pjenvey
previously approved these changes
Nov 6, 2025
The hostname in the metrics could significantly increase the cardinality. This patch make the inclusion of the hostname optional, with a default of false.
chenba
force-pushed
the
refactor/hostname-optional-metrics-STOR-393
branch
from
6a47c67 to
7c8549c
Compare
pjenvey
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The hostname in the metrics could significantly increase the cardinality. This patch make the inclusion of the hostname optional, with a default of false.
Testing
All existing tests should pass.
Issue(s)
Closes STOR-393 / #1859