Skip to content

[menu][context menu] Add SubmenuRoot part #2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 16, 2025
Merged

[menu][context menu] Add SubmenuRoot part #2042

merged 7 commits into from
Jun 16, 2025

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Jun 2, 2025 •
edited
Loading

Closes #2038

Context Menu: https://deploy-preview-2042--base-ui.netlify.app/experiments/context-menu
Menu: https://deploy-preview-2042--base-ui.netlify.app/experiments/menu/complex-nesting

This allows ContextMenu to have a SubmenuTrigger part as it disambiguates a submenu from a new but nested root menu. Also should address cases where a Dialog trigger is a Menu item, with a nested Menu inside.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 2, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@base-ui-components/react@2042

commit: 74d5239

@netlify Netlify
Copy link

netlify bot commented Jun 2, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 74d5239
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/685023799b51b70008c9e976
😎 Deploy Preview https://deploy-preview-2042--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks force-pushed the feat/menu-submenuroot branch from f132136 to 3d20d00 Compare June 2, 2025 13:00
@mui-bot
Copy link

mui-bot commented Jun 2, 2025 •
edited
Loading

Bundle size report

Total Size Change: 🔺+1.38KB(+0.09%) - Total Gzip Change: 🔺+381B(+0.08%)
Files: 41 total (0 added, 0 removed, 3 changed)

Show details for 41 more bundles

@base-ui-components/react/context-menu parsed: 🔺+997B(+0.89%) gzip: 🔺+265B(+0.72%)
@base-ui-components/react parsed: 🔺+214B(+0.07%) gzip: 🔺+51B(+0.05%)
@base-ui-components/react/menu parsed: 🔺+172B(+0.15%) gzip: 🔺+65B(+0.17%)
@base-ui-components/react/accordion parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/alert-dialog parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/avatar parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/checkbox parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/checkbox-group parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/collapsible parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/dialog parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/direction-provider parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/field parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/fieldset parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/form parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/input parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/menubar parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/merge-props parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/meter parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/navigation-menu parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/number-field parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/popover parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/preview-card parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/progress parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/radio parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/radio-group parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/scroll-area parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/select parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/separator parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/slider parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/switch parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/tabs parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/toast parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/toggle parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/toggle-group parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/toolbar parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/tooltip parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/unstable-no-ssr parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/unstable-use-media-query parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/use-render parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/utils parsed: 0B(0.00%) gzip: 0B(0.00%)
Base UI checkbox parsed: 0B(0.00%) gzip: 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 74d5239

@atomiks atomiks force-pushed the feat/menu-submenuroot branch from 05fb87f to 5c59c32 Compare June 2, 2025 13:03
@atomiks atomiks marked this pull request as ready for review June 2, 2025 13:08
@atomiks atomiks force-pushed the feat/menu-submenuroot branch from 5c59c32 to 4d3e099 Compare June 2, 2025 13:52
michaldudak
michaldudak reviewed Jun 2, 2025
View reviewed changes
@atomiks atomiks force-pushed the feat/menu-submenuroot branch from 7f6e3fb to 23b3285 Compare June 3, 2025 04:04
@michaldudak
Copy link
Member

The Anatomy and Nested menu sections in the docs need an update.

@atomiks atomiks merged commit 441bc81 into mui:master Jun 16, 2025
21 checks passed
@atomiks atomiks deleted the feat/menu-submenuroot branch June 16, 2025 14:08
@atomiks atomiks mentioned this pull request Jun 16, 2025
Merged
@mj12albert mj12albert mentioned this pull request Jun 23, 2025
Open
@mj12albert mj12albert linked an issue Jun 23, 2025 that may be closed by this pull request
[menu] Nested menu items do not respect closeOnClick={false} if root menu has openOnHover #2000
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

Assignees
No one assigned
Labels
breaking change component: context menu component: menu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[menu] Nested menu items do not respect closeOnClick={false} if root menu has openOnHover [context menu] Sub root part
3 participants
@atomiks @mui-bot @michaldudak