Skip to content

[preview card] Integrate inline positioning #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Jun 6, 2025

Part of #2064
Previously it would choose the whole bounding client rect rather than choosing an individual client rect. align="start" sort of alleviates this problem but you can't use center positioning or other sides.

https://deploy-preview-2074--base-ui.netlify.app/experiments/inline-positioning

Screen.Recording.2025-06-06.at.4.21.44.pm.mov

@atomiks atomiks added enhancement This is not a bug, nor a new feature component: preview card labels Jun 6, 2025
Copy link

pkg-pr-new bot commented Jun 6, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@base-ui-components/react@2074

commit: 04fe93c

@mui-bot
Copy link

mui-bot commented Jun 6, 2025

Bundle size report

Total Size Change:${\tiny{\color{red}▲}}$+4.75KB(+0.33%) - Total Gzip Change:${\tiny{\color{red}▲}}$+1.67KB(+0.35%)
Files: 41 total (0 added, 0 removed, 8 changed)

@base-ui-components/reactparsed:${\tiny{\color{red}▲}}$+2.23KB(+0.74%) gzip:${\tiny{\color{red}▲}}$+780B(+0.86%)
@base-ui-components/react/preview-cardparsed:${\tiny{\color{red}▲}}$+2.23KB(+3.84%) gzip:${\tiny{\color{red}▲}}$+787B(+3.97%)

Show 6 more bundle changes

@base-ui-components/react/selectparsed:${\tiny{\color{red}▲}}$+52B(+0.05%) gzip:${\tiny{\color{red}▲}}$+9B(+0.02%)
@base-ui-components/react/context-menuparsed:${\tiny{\color{red}▲}}$+48B(+0.04%) gzip:${\tiny{\color{red}▲}}$+9B(+0.02%)
@base-ui-components/react/navigation-menuparsed:${\tiny{\color{red}▲}}$+48B(+0.06%) gzip:${\tiny{\color{red}▲}}$+20B(+0.07%)
@base-ui-components/react/tooltipparsed:${\tiny{\color{red}▲}}$+48B(+0.08%) gzip:${\tiny{\color{red}▲}}$+21B(+0.10%)
@base-ui-components/react/menuparsed:${\tiny{\color{red}▲}}$+46B(+0.04%) gzip:${\tiny{\color{red}▲}}$+21B(+0.06%)
@base-ui-components/react/popoverparsed:${\tiny{\color{red}▲}}$+46B(+0.05%) gzip:${\tiny{\color{red}▲}}$+27B(+0.09%)

Details of bundle changes

Generated by 🚫 dangerJS against 04fe93c

@atomiks atomiks force-pushed the feat/preview-card-tooltip-inline branch from f6338d2 to 1158c4c Compare June 6, 2025 06:31
Copy link

netlify bot commented Jun 6, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit f6338d2
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/68428a96c359ff000840bf20
😎 Deploy Preview https://deploy-preview-2074--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks force-pushed the feat/preview-card-tooltip-inline branch 2 times, most recently from 1f4d6cc to cde5577 Compare June 6, 2025 06:37
@mui mui deleted a comment from netlify bot Jun 6, 2025
@mui mui deleted a comment from netlify bot Jun 6, 2025
@atomiks atomiks force-pushed the feat/preview-card-tooltip-inline branch from cde5577 to 04fe93c Compare June 6, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: preview card enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants