Skip to content

[select] Fix re-render warning in Positioner on fallback #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2025
Merged

[select] Fix re-render warning in Positioner on fallback #2089

merged 2 commits into from
Jun 12, 2025

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Jun 10, 2025

The set-state-in-render pattern only works if the state is local to the component, otherwise it needs to use an effect now that it's in the store.

To reproduce the warning before, just open the select close to the edge of the viewport so it enters fallback mode

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 10, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@base-ui-components/react@2089

commit: c76aa92

@mui-bot
Copy link

mui-bot commented Jun 10, 2025 •
edited
Loading

Bundle size report

Total Size Change: 🔺+44B(0.00%) - Total Gzip Change: 🔺+16B(0.00%)
Files: 41 total (0 added, 0 removed, 2 changed)

Show details for 41 more bundles

@base-ui-components/react parsed: 🔺+22B(+0.01%) gzip: 🔺+8B(+0.01%)
@base-ui-components/react/select parsed: 🔺+22B(+0.02%) gzip: 🔺+8B(+0.02%)
@base-ui-components/react/accordion parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/alert-dialog parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/avatar parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/checkbox parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/checkbox-group parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/collapsible parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/context-menu parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/dialog parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/direction-provider parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/field parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/fieldset parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/form parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/input parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/menu parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/menubar parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/merge-props parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/meter parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/navigation-menu parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/number-field parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/popover parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/preview-card parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/progress parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/radio parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/radio-group parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/scroll-area parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/separator parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/slider parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/switch parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/tabs parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/toast parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/toggle parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/toggle-group parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/toolbar parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/tooltip parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/unstable-no-ssr parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/unstable-use-media-query parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/use-render parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/utils parsed: 0B(0.00%) gzip: 0B(0.00%)
Base UI checkbox parsed: 0B(0.00%) gzip: 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against c76aa92

@atomiks atomiks marked this pull request as ready for review June 10, 2025 09:01
@netlify Netlify
Copy link

netlify bot commented Jun 10, 2025

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit f93754e
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6847f3fb03b7e50008ce9a4d
😎 Deploy Preview https://deploy-preview-2089--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify Netlify
Copy link

netlify bot commented Jun 10, 2025

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit c76aa92
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6847f4766f383000084c8675
😎 Deploy Preview https://deploy-preview-2089--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks requested a review from romgrk June 10, 2025 09:09
@mj12albert
Copy link
Member

By fallback mode you mean item-not-aligned-to-trigger like this right? I couldn't reproduce a warning 🤔 @atomiks

Screenshot 2025-06-12 at 9 37 52 AM

@atomiks
Copy link
Contributor Author

atomiks commented Jun 12, 2025

@mj12albert yeah that's right, but I think it only happens in dev mode

@atomiks atomiks merged commit 7ca8cd9 into mui:master Jun 12, 2025
22 checks passed
@atomiks atomiks deleted the fix/select-positioner-warning branch June 12, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romgrk romgrk romgrk approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

Assignees
No one assigned
Labels
component: select
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atomiks @mui-bot @mj12albert @romgrk