-
-
Notifications
You must be signed in to change notification settings - Fork 142
[docs] Fix incorrect links in TOC on releases page #2150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
57450e6
to
c23502c
Compare
commit: |
Bundle size report@base-ui-components/react parsed: 0B(0.00%) gzip: 0B(0.00%) Show details for 39 more bundles@base-ui-components/react/accordion parsed: 0B(0.00%) gzip: 0B(0.00%) |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
let index = parent.children.indexOf(node); | ||
|
||
// eslint-disable-next-line no-plusplus | ||
while (index--) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how the official util does it: https://github.com/syntax-tree/unist-util-find-before
Though I didn't think we need to add it as a dependency just for this
|
||
// https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string | ||
const SEMVER_PATTERN = | ||
/^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$/gm; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's define it just once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, deleted it as it was moved to the other file
Preview: https://deploy-preview-2150--base-ui.netlify.app/react/overview/releases#v1.0.0-beta.0-general-changes
The
id
s of headings on the releases page which can be duplicate are prefixed with the related version string to make them unique.