Log unexpected elements when strict is False #899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThreePinkApples
force-pushed
the
unexpected_element
branch
from
d27db2f to
47bf171
Compare
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
==========================================
+ Coverage 89.38% 89.39% +<.01%
==========================================
Files 65 65
Lines 4825 4828 +3
Branches 842 843 +1
==========================================
+ Hits 4313 4316 +3
Misses 331 331
Partials 181 181
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
==========================================
+ Coverage 89.38% 89.39% +<.01%
==========================================
Files 65 65
Lines 4825 4828 +3
Branches 842 843 +1
==========================================
+ Hits 4313 4316 +3
Misses 331 331
Partials 181 181
|
ThreePinkApples
force-pushed
the
unexpected_element
branch
from
47bf171 to
ee2d67e
Compare
Contributor
Author
|
Was browsing my GitHub history and noticed this. Rebased with master :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting strict to False can be a risky move, but possibly a necessary workaround. It is then good to have all the unexpected elements to be logged, to help with debugging any issues that would have been caught with strict=True