Skip to content
This repository was archived by the owner on Jun 10, 2025. It is now read-only.

List comprehension, literal comparison, import ordering, staticmethod #133

Merged
merged 5 commits into from
Mar 2, 2021

Conversation

dericke
Copy link
Contributor

@dericke dericke commented Dec 15, 2020

  • Reorder imports to PEP8
  • Replace a create-then-append pattern with a list comprehension
  • Use != instead of is not to compare strings
  • Reduce indenting by raising early in a guard condition
  • Change a @classmethod that did not reference its class to a @staticmethod

If it would be helpful/appropriate, I would be happy to break these up into multiple small PRs instead.

@mvexel mvexel merged commit ff51d63 into mvexel:master Mar 2, 2021
@dericke dericke deleted the refactor branch March 4, 2021 16:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants