Skip to content
This repository was archived by the owner on Jun 10, 2025. It is now read-only.

Adding version to the geojson elements #156

Closed
wants to merge 1 commit into from

Conversation

viksuper555
Copy link

Fixes #155

@viksuper555
Copy link
Author

I would like to hear your feedback on this.

P.S. The tests seem broken, although my changes don't really affect them.

@mvexel
Copy link
Owner

mvexel commented Mar 10, 2023

Hi, thanks for this! I'll have a look.

@mvexel
Copy link
Owner

mvexel commented Feb 5, 2024

Sorry @viksuper555 I have been so busy with life things. I'll have a look!

@mvexel mvexel mentioned this pull request Feb 7, 2024
@mvexel
Copy link
Owner

mvexel commented Feb 7, 2024

version is already available in the feature properties when get() is called with verbosity="meta": https://github.com/mvexel/overpass-api-python-wrapper/blob/main/overpass/api.py#L315

We can discuss if that is the right place for it, but I would like to avoid having the same information in the output twice. Thoughts?

@mvexel
Copy link
Owner

mvexel commented Feb 12, 2024

@viksuper555 As commented on #155 -- this information is available so I will not merge this. Thanks for the effort though, and if you have any concerns with the way the metadata is exposed, don't hesitate to come back and discuss.

@mvexel mvexel closed this Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrapper doesn't return OSM Feature version.
2 participants