Skip to content

Conversation

@grarco
Copy link
Contributor

@grarco grarco commented Oct 24, 2025

Adds documentation on how to use masp frontend sustainability fees from the SDK (based on https://github.com/namada-net/namada/pull/4790/files)

@grarco grarco requested a review from brentstone October 24, 2025 13:24

<Callout type="warning">
For fully shielded osmosis swaps (from shieleded address to shielded address),
the operator should refrain from charging a fee.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why should the operator refrain from charging a fee? I think a small justification is worthwhile here.

where the first element of the tuple is the receiver of the fee (an address
controlled by the operator) and the second one is the fee expressed as a
percentage of the shielded/unshielded amount. This percentage will be charged on
top of the amount specified by the user.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write some more details about what the operator can expect to happen each time a user transacts with the MASP? For example, will an extra tx be generated and asked to be signed that pays fees?

Comment on lines +68 to +76
For transactions that move assets into or out of the shielded pool, the namada
SDK provides the possibility to charge an optional fee to support the operations
of the frontend provider. The specific transactions are:

- `TxShieldingTransfer`
- `TxUnshieldingTransfer`
- `TxOsmosisSwap`
- `TxIbcTransfer`
- `GenIbcShieldingTransfer`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you provide some more detail on the general flow? Are operators expected to build their own instance of Namadillo on top of some release that makes certain SDK additions? Sorry I kinda have no idea myself. I think there should be more detail on how to integrate the SDK changes into one's own hosted Namada (or let me know if this is obvious and I'm just clueless)

Copy link
Contributor

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind providing some more detail here in general? See specific comments and questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants