-
Notifications
You must be signed in to change notification settings - Fork 694
[compute] fix: background worker that collects installed extension metrics now updates collection interval #12277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…abort task during shutdown
8481 tests run: 7898 passed, 0 failed, 583 skipped (full report)Flaky tests (2)Postgres 17
Postgres 16
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
0574ecc at 2025-06-18T00:11:58.558Z :recycle: |
What is the justification for the atomicity? |
Where is the code for this? |
There's a PR on control plane side: https://github.com/neondatabase/cloud/pull/30318 The updation logic is here (for the worker) and the actual value is updated in reconfigure |
The interval is in an |
Problem
Previously, the background worker that collects the list of installed extensions across DBs had a timeout set to 1 hour. This cause a problem with computes that had a
suspend_timeout
> 1 hour as this collection was treated as activity, preventing compute shutdown.Issue: https://github.com/neondatabase/cloud/issues/30147
Summary of changes
Passing the
suspend_timeout
as part of theComputeSpec
so that any updates to this are taken into account by the background worker and updates its collection interval.