feat(eslint): add vim.lsp.config support #3731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
reviewed
Apr 16, 2025
dorage
reviewed
Apr 16, 2025
crnvl96
force-pushed
the
master
branch
2 times, most recently
from
fd58769 to
17cd611
Compare
|
Thanks for the work on this, I was just about to begin my attempt at this change, and then saw yours! |
seblyng
reviewed
Apr 16, 2025
seblyng
reviewed
Apr 16, 2025
seblyng
reviewed
Apr 16, 2025
crnvl96
force-pushed
the
master
branch
2 times, most recently
from
df5d577 to
05a7db0
Compare
seblyng
approved these changes
Apr 17, 2025
justinmk
reviewed
Apr 18, 2025
justinmk
reviewed
Apr 18, 2025
justinmk
reviewed
Apr 18, 2025
|
Totally agree with your suggestions, they should be fixed now. Actually, my goal was mainly to port the old config with as few changes as possible. |
seblyng
approved these changes
Apr 18, 2025
justinmk
reviewed
Apr 21, 2025
justinmk
reviewed
Apr 21, 2025
This was referenced Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR crosses
eslintfrom #3705Compared locally against the current implementation from
lua/lspconfig/configs/eslint.luaans seems ok, but I'm open for more specific checks or any kind of improvement you may have.