feat: angularls #3746
Merged
feat: angularls #3746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
reviewed
Apr 18, 2025
| end) | ||
| :join(',') | ||
|
|
||
| ---@brief |
There was a problem hiding this comment.
should be at top of the file
justinmk
reviewed
Apr 18, 2025
| end | ||
|
|
||
| local default_probe_dir = get_probe_dir() | ||
| local default_angular_core_version = get_angular_core_version() |
There was a problem hiding this comment.
evaluating this here (and getcwd() above) means that if the user changes the CWD later, that won't be used by the config.
It seems like cwd should be defined as a function for this config, instead of a list. That makes it more "dynamic".
The old config https://github.com/neovim/nvim-lspconfig/blob/master/lua/lspconfig/configs/angularls.lua had this issue too, though, so I guess this can be revisited later...
|
This config has problems which broke the doc generator. I mitigated the issue in e8963b5 , but the logic needs attention... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR crosses angularls from #3705
mainly same with
lua/lspconfig/configs/angularls.luaon_new_configas I test locally it doesn't matter