feat(glint): add vim.lsp.config support #3911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
reviewed
Jun 17, 2025
Comment on lines
+41
to
+43
| config.cmd = { | ||
| 'exec', | ||
| root_dir .. '/node_modules/.bin/glint-language-server', |
There was a problem hiding this comment.
I don't think this will do what is expected. before_init happens after the server was starting.
If cmd needs to be dynamic it must be defined as a function.
There was a problem hiding this comment.
Ah you are right. Looks like it just changed the config, but it did not have an effect.
|
Might need an improvement as mentioned above, but can be a followup if you find the inspiration :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this one was still missing in the list in #3705.
I tested it by creating a new ember ts project ->
ember new my-typescript-app --typescriptthen adding glint to that project ->
npm install --save-dev @glint/corePer default we use the project local glint-language-server, but the user can also choose to use a globally installed version.
Based on lua/lspconfig/configs/glint.lua