-
Notifications
You must be signed in to change notification settings - Fork 14
Docs: Readme content added #78
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request @nishtha53!
It looks like the npm modules weren't installed so prettier did not run which is why the pull requests checks are failing.
8:45:03 AM: > prettier --plugin-search-dir . --check . && eslint .
8:45:04 AM: Checking formatting...
8:45:04 AM: [warn] README.md
8:45:05 AM: [warn] Code style issues found in the above file. Forgot to run Prettier?
- Make sure you follow the guidelines to install the project locally, i.e. run
npm install
. See https://github.com/nickytonline/connect-four#local-development - You'll need to run
npm run format
as it didn't run automatically when you committed your code initially.
|
||
### How to work with Storybook? | ||
|
||
1. Run the app with `npm run storybook` | ||
2. How to build it by running? - `npm run build-storybook` | ||
3. Story Book Official documentation | ||
- [Guides](https://storybook.js.org/docs/react/get-started/introduction) | ||
|
||
- [Tutorials](https://storybook.js.org/tutorials/) | ||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some wording changes. Also, I know I said add how to build it, but we can omit that. It's really only required for deploying Storybook.
### How to work with Storybook? | |
1. Run the app with `npm run storybook` | |
2. How to build it by running? - `npm run build-storybook` | |
3. Story Book Official documentation | |
- [Guides](https://storybook.js.org/docs/react/get-started/introduction) | |
- [Tutorials](https://storybook.js.org/tutorials/) | |
### Working with Storybook | |
1. To start Storybook, run `npm run storybook` | |
2. For more information on Storybook, see the Official documentation | |
- [Guides](https://storybook.js.org/docs/react/get-started/introduction) | |
- [Tutorials](https://storybook.js.org/tutorials/) | |
Okay I will work on this changes |
@nickytonline in my local I have installed all packages and done with readme part still showing merging block |
I'll pull down your pull request and see what's up. |
okay sure do let me know. |
There's still some formatting errors but I can't push changes from my local machine as I do not have access to your branch. From your local machine, do the following.
|
@nickytonline I followed same steps which you told but same merging is still blocked. |
What type of PR is this? (check all applicable)
Description
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
UI accessibility concerns?
If your PR includes UI changes, please replace this line with details on how
accessibility is impacted and tested. For more info, check out the awesome
Forem Accessibility Docs.
Added/updated tests?
have not been included