Skip to content

Conversation

nicolas-grekas
Copy link
Contributor

A similar fix is needed on master

Copy link
Owner

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this branch alias should just be dropped. Especially on the 4.x branch having a dev-master alias doesn't really make sense?

@nicolas-grekas nicolas-grekas changed the title Fix branch-alias Drop branch-alias on 4.x Aug 13, 2025
@nicolas-grekas
Copy link
Contributor Author

of course! PR updated.

@nikic nikic merged commit c95b500 into nikic:4.x Aug 13, 2025
11 checks passed
@pk-fr
Copy link

pk-fr commented Sep 10, 2025

this change breaks my php obfuscator :

I need a way to know which PHP-Parser version is installed to make sure that the version is ok with the obfuscator...
I was using branch-alias to determine the version...
Please offer a way to do that: for exemple a version.php file

thanx in advance!

@nicolas-grekas nicolas-grekas deleted the br-alias branch September 10, 2025 10:31
@nicolas-grekas
Copy link
Contributor Author

nicolas-grekas commented Sep 10, 2025

You should use the Composer\InstalledVersions class for that. It's in your vendor/composer directory.

@pk-fr
Copy link

pk-fr commented Sep 10, 2025

I do not use composer!
I use git clone

@nikic
Copy link
Owner

nikic commented Sep 10, 2025

Parsing the changelog may be an option.

@pk-fr
Copy link

pk-fr commented Sep 10, 2025

Parsing the changelog may be an option.

It is the work-around that I will have to do, if PHP-Parser do not provide easy and standard way for getting it's version...
As you may imagine, I would prefer just having an include file that will have a variable or a function getting the version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants