Skip to content

Revert "plugins/lsp: use vim.lsp native API" #3233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

MattSturgeon
Copy link
Member

@MattSturgeon MattSturgeon commented Apr 27, 2025

This reverts commit 78f6ff0 from #3204

See discussion: #3204 (comment)

I think we may have to revert this for a while, as not all nvim-lspconfig configs are updated to work with the new API.

Our users are running into issues like:

Which may not be fully resolvable until neovim/nvim-lspconfig#3705 is complete and propagated to nixpkgs.

Hopefully we will be able to un-revert soon, once nvim-lspconfig has updated the remaining configs.

Users can test by overriding their flake input:

nix flake lock --override-input nixvim 'github:nix-community/nixvim?ref=pull/3233/merge'

Then they should try using their config, e.g. with nix run .#nvim. In particular, you should check :checkhealth vim.lsp has your LSPs configured correctly.

Fixes #3217
Fixes #3224

@MattSturgeon

This comment was marked as resolved.

This comment was marked as resolved.

Copy link
Contributor

mergify bot commented Apr 28, 2025

This pull request, with head sha 3ea2ce7ff66e040876c63028c37f906ff1748434, has been successfully merged with fast-forward by Mergify.

This pull request will be automatically closed by GitHub.

As soon as GitHub detects that the sha 3ea2ce7ff66e040876c63028c37f906ff1748434 is part of the main branch, it will mark this pull request as merged.

It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch revert-lsp, this means GitHub will fail to detect the merge.

@mergify mergify bot merged commit 3ea2ce7 into nix-community:main Apr 28, 2025
4 checks passed
@mergify mergify bot temporarily deployed to github-pages April 28, 2025 12:29 Inactive
@MattSturgeon MattSturgeon deleted the revert-lsp branch April 28, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] nvim-lspconfig default configuration missing for eslint [BUG] Omisharp LSP fails to attach
2 participants