Fixes concurrent downloads of the same Yarn binary #764
+21
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
force-pushed
the
mael/concurrent-corepack
branch
from
b840767 to
321fdf0
Compare
aduh95
reviewed
Nov 7, 2025
aduh95
reviewed
Nov 7, 2025
aduh95
reviewed
Nov 7, 2025
aduh95
reviewed
Nov 7, 2025
aduh95
reviewed
Nov 7, 2025
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a check allowing the
renameoperation to fail for tarballs, but forgot to do the same for the single JS file downloaded in the Yarn codepath. As a result the operation could fail when two processes are downloading the exact same version. I got this error on Netlify when trying to install multiple git dependencies from the same repository.Unfortunately no tests, as it's a race condition so not sure I can easily test that without making the tests flaky 🫤