-
Notifications
You must be signed in to change notification settings - Fork 3
Add changelog casting optionals to str according to schema #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
nvdaes
commented
Oct 13, 2025
- Add changelog
- Add changelog to json schema
- Address code review
- Update _validate/addonVersion_schema.json
- Apply suggestions from code review
- Address review
- Address review
- Assign None to changelog when appropriate
- Pre-commit auto-fix
- Fix
- Fix
- Remove unassigned addonData
- Fix test
- Fix error message
- harmonize test for changelog with homepage
- Fix test
- Remove function
- Commend python preference to test locally
- Lint fixes
- Add translated changelog optional and fix linting errors by casting to str
- Fix pyproject
- Add ignore type comments
- Add ignore type comment
- Address review
- Address review
- Remove accidentally committed files
- Try to ensure that homepage and changelog are str or None
- Address feedback
- Apply suggestions from code review
- Apply suggestions from code review
- Apply suggestions from code review
- Update _validate/createJson.py
- Apply review suggestions
- Update createJson casting fields to str according to schema
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Sean Budd <[email protected]>
@seanbudd , I'll test with this. I think we should cast optionals to str according to json schema to create the json file, since a string is expected, not None. |
…t would be str, according to json schema
@nvdaes - please keep this as None and avoiding casting to strings as requested in #48 (comment) We should be able to handle None values safely |
Sean wrote:
I've added the null type to some properties. I wonder if we should make the description optional, and in this case, if it should be a required field in the json schema and translations. I'll wait for your feedback before moving forward. |