Skip to content

Conversation

nvdaes
Copy link
Contributor

@nvdaes nvdaes commented Oct 13, 2025

  • Add changelog
  • Add changelog to json schema
  • Address code review
  • Update _validate/addonVersion_schema.json
  • Apply suggestions from code review
  • Address review
  • Address review
  • Assign None to changelog when appropriate
  • Pre-commit auto-fix
  • Fix
  • Fix
  • Remove unassigned addonData
  • Fix test
  • Fix error message
  • harmonize test for changelog with homepage
  • Fix test
  • Remove function
  • Commend python preference to test locally
  • Lint fixes
  • Add translated changelog optional and fix linting errors by casting to str
  • Fix pyproject
  • Add ignore type comments
  • Add ignore type comment
  • Address review
  • Address review
  • Remove accidentally committed files
  • Try to ensure that homepage and changelog are str or None
  • Address feedback
  • Apply suggestions from code review
  • Apply suggestions from code review
  • Apply suggestions from code review
  • Update _validate/createJson.py
  • Apply review suggestions
  • Update createJson casting fields to str according to schema

@nvdaes nvdaes changed the title changelog Add changelog casting optionals to str according to schema Oct 13, 2025
@nvdaes
Copy link
Contributor Author

nvdaes commented Oct 13, 2025

@seanbudd , I'll test with this. I think we should cast optionals to str according to json schema to create the json file, since a string is expected, not None.

@seanbudd
Copy link
Member

@nvdaes - please keep this as None and avoiding casting to strings as requested in #48 (comment)

We should be able to handle None values safely

@nvdaes
Copy link
Contributor Author

nvdaes commented Oct 14, 2025

Sean wrote:

We should be able to handle None values safely

I've added the null type to some properties. I wonder if we should make the description optional, and in this case, if it should be a required field in the json schema and translations. I'll wait for your feedback before moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants