feat(json): add abliity to remove trailing commas while stripping comments #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Conni2461 sorry for the noise! I just wanted to check in and see if there was any way that this PR could get reviewed :) |
mehalter
force-pushed
the
json_trailing_commas
branch
from
f43675a to
0904e46
Compare
|
thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an additional feature to the
json_strip_commentsfunction that adds more compatibility for converting a JSON string to something compatible withvim.fn.json_decode. I also added tests to make sure things like commas in strings are fully ignored and that it doesn't mess up the already existing comment stripping.Resolves #612