Merge upstream #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is currently processing.
Fix failing test in worker spec
Enforces userId anonId requirement
* Fix typo and split sample use into different code blocks
Revert "Enforces userId anonId requirement"
Revert "Fix failing test in worker spec"
* Use latest 2.1 release (2.1.10). * Add latest 2.2, 2.3 and 2.4 releases.
ActiveSupport is used as a testing dependency to ensure that ActiveSupport::TimeWithZone objects are converted to iso8601 format correctly. Because of recent changes in ActiveSupport, there is a change in the way `DateTime`s are converted to `Time`s, specs have been changed to reflect that. Reference: rails/rails@b79adc4
When calling `enqueue` on the client, it automatically spawns a worker thread to consume items from the queue. This causes race conditions between the tests and worker picking items from `queue`.
Update activesupport dependency
* Add rubocop (style linter), run as part of default rake task * Generate rubocop_todo.yml * Autocorrect simple cops * Use consistent style for indenting hashes * Auto-correct cops * Avoid redefining #stub via attr_accessor * Avoid assignment within condition * Avoid suppressing exception in spec_helper.rb * Auto-correct cops * Autocorrect symbol arrays * Auto-correct string literals * Auto-correct quotes within interpolation * Autocorrect raising exceptions * Avoid using semi-colon as a separator * Set target ruby version * Auto-correct Proc style * Specify 'verbose' style for Hash#has_key? * Allow parallel assignment * Allow 6 digits without underscores * Allow mutable constants This behaviour could've been relied on by users, not worth changing. * Avoid multi-line if modifier usage * Use parentheses for all method definitions * Allow 1.9 hash syntax in specs * Allow one-liners to be wrapped in conditionals * Allow % for formatting * Use each_with_object instead of inject * Allow DateTime in specs * Remove colon method call * Allow bracket symbol arrays * Disable doc checks * Allow all block delimiters in specs * Remove non-ascii quote in comment * Allow is_requesting? as an exception for predicate names * Disable BracesAroundHashParameters check * Move legit items from .rubucop_todo.yml to .rubocop.yml * Disable metrics check for specs
* Separate request construction logic from retries * Trim lines in request_spec.rb to < 80 chars * Add function to retry a block without exceptions raised * Retry requests on HTTP status code errors
Add analytics-ruby.rb for easier Gemfile use
Update codecov
…lytics-ruby into Issue-268-Raise-Error
Push raising error message
Update Release notes
Release 2.5.0.
Removing github gem publish step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
30 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.