Skip to content

fix(app/quiz): disable challenge button based on date limits #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 19, 2025

Conversation

huzhengen
Copy link
Contributor

修改 #213

没到开始时间,或者过了结束时间,就把按钮 disabled。

Copy link

vercel bot commented Apr 18, 2025

@huzhengen is attempting to deploy a commit to the OpenBuild Team on Vercel.

A member of the Team first needs to authorize it.

@zhang-wenchao
Copy link
Collaborator

直接置灰感觉不太合适,可以更改文字,如果没有到开始时间是 Waiting to start 结束了就是 End 会不会好点?

@zhang-wenchao
Copy link
Collaborator

另外需要注意时间戳是秒,Date.now() 是毫秒。

@huzhengen
Copy link
Contributor Author

直接置灰感觉不太合适,可以更改文字,如果没有到开始时间是 Waiting to start 结束了就是 End 会不会好点?

按这个修改了。没到开始时间显示 Waiting to start,过了结束时间显示 End。

@ourai ourai self-requested a review April 19, 2025 02:31
@ourai ourai self-assigned this Apr 19, 2025
@ourai ourai added the bug Something isn't working label Apr 19, 2025
@ourai ourai added this to the 2025W16 milestone Apr 19, 2025
Copy link
Member

@ourai ourai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在组件内返回 JSX 的上方写一个返回按钮文本和 onClick 处理函数的函数,在那里进行计算逻辑处理。

JSX 中有逻辑增加很多重复字符,显得代码很「脏」。

建议牢记于心——

实现功能是基本要求,力争写出简洁优雅甚至让人惊呼的代码!🦾

@ourai ourai moved this from Todo to In Progress in OpenBuild Official Website Apr 19, 2025
@ourai ourai linked an issue Apr 19, 2025 that may be closed by this pull request
Copy link
Member

@ourai ourai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没按照我 #219 (review) 说的做呀,这跟没改有啥区别?😅

Copy link

vercel bot commented Apr 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
openbuild-frontend ✅ Ready (Inspect) Visit Preview Apr 19, 2025 5:37pm

@ourai ourai merged commit be9c454 into openbuildxyz:test Apr 19, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Closed in OpenBuild Official Website Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

quiz 答题需要遵循开始结束时间
3 participants