-
Notifications
You must be signed in to change notification settings - Fork 39
fix(app/quiz): disable challenge button based on date limits #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@huzhengen is attempting to deploy a commit to the OpenBuild Team on Vercel. A member of the Team first needs to authorize it. |
直接置灰感觉不太合适,可以更改文字,如果没有到开始时间是 Waiting to start 结束了就是 End 会不会好点? |
另外需要注意时间戳是秒, |
按这个修改了。没到开始时间显示 Waiting to start,过了结束时间显示 End。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在组件内返回 JSX 的上方写一个返回按钮文本和 onClick
处理函数的函数,在那里进行计算逻辑处理。
JSX 中有逻辑增加很多重复字符,显得代码很「脏」。
建议牢记于心——
实现功能是基本要求,力争写出简洁优雅甚至让人惊呼的代码!🦾
…ty and maintainability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没按照我 #219 (review) 说的做呀,这跟没改有啥区别?😅
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
修改 #213
没到开始时间,或者过了结束时间,就把按钮 disabled。