Fix ZFS_READONLY implementation on Linux #17837
Open
+2
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MS-FSCC 2.6 is the governing document for DOS attribute behavior. It specifies the following: For a file, applications can read the file but cannot write to it or delete it. For a directory, applications cannot delete it, but applications can create and delete files from the directory. Signed-off-by: Andrew Walker <[email protected]>
ixhamza
approved these changes
Oct 10, 2025
allanjude
reviewed
Oct 12, 2025
| err = SET_ERROR(EPERM); | ||
| goto out3; | ||
| } | ||
| /* ZFS_READONLY will be handled in zfs_zaccess() */ |
There was a problem hiding this comment.
Is it not handled in zfs_zaccess()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MS-FSCC 2.6 is the governing document for DOS attribute behavior.
It specifies the following:
For a file, applications can read the file butcannot write to it or delete it. For a directory,
applications cannot delete it, but applications can create and delete files from the directory.
Motivation and Context
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.