Update Disk.js - add used/total GB info #9131
Conversation
Add used / total GB disk space used info to Disk widget
|
|
I like it :) |
| const totalBytes = usedBytes + freeBytes; | ||
| const usedGB = this._formatGB(usedBytes); | ||
| const totalGB = this._formatGB(totalBytes); | ||
| return `(${usedGB}/${totalGB}) GB`; |
There was a problem hiding this comment.
The () looks misplaced before the GB, may be better to just omit and free the space used by it.
There was a problem hiding this comment.
It looks the same as the memory widget, but I agree the parenthesis aren't useful. Then the memory widget would have to be adjusted (easily done).
| */ | ||
|
|
||
| _formatGB(bytes) { | ||
| return (bytes / (1000 * 1000 * 1000)).toFixed(1); |
There was a problem hiding this comment.
I think this is too simplistic as it should adapt to k M G T...
There was a problem hiding this comment.
This kind of formatter could be added to the BaseWidget I think.
E.g. here is one the UI uses in multiple places.
core/src/opnsense/www/js/opnsense_ui.js
Line 37 in 5875c18
There was a problem hiding this comment.
Yes, that would make more sense. My reasoning was that storage for such a device would be within XX GB and XXX GB - but we know how that ends up :)
5 participants
Add used / total GB disk space used info to Disk widget