-
Notifications
You must be signed in to change notification settings - Fork 220
PoC: Report status to Gitea when scheduled product finishes #6774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally good. If cleaned up we could merge it as this is generally a good first step to supporting more than one VCS provider.
1230530 to
3a3c6b3
Compare
3a3c6b3 to
9957f4b
Compare
| # TODO Note that anyone who can create an openQA job can set settings | ||
| # with a webhook id and a statuses URL. Maybe we should configure the | ||
| # base url for each git provider and double check the url, because | ||
| # we are making an API request with a token to an otherwise unchecked URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just commenting to be able to link to this more easily
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should definitely add such a check.
| my $tx = $self->SUPER::create_request($params); | ||
|
|
||
| my $headers = $tx->req->headers; | ||
| # TODO there might be more than one gitea server -> add sections? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just commenting to be able to link to this more easily
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to be able to configure one token per instance, so yes we probably need multiple sections.
Issue: https://progress.opensuse.org/issues/185491
So far only rewrote existing code to be able to deal with more than just github