Skip to content

Conversation

@perlpunk
Copy link
Contributor

Issue: https://progress.opensuse.org/issues/185491

So far only rewrote existing code to be able to deal with more than just github

Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good. If cleaned up we could merge it as this is generally a good first step to supporting more than one VCS provider.

@perlpunk perlpunk force-pushed the gitea-webhook-api branch 3 times, most recently from 1230530 to 3a3c6b3 Compare September 26, 2025 21:30
Comment on lines +25 to +28
# TODO Note that anyone who can create an openQA job can set settings
# with a webhook id and a statuses URL. Maybe we should configure the
# base url for each git provider and double check the url, because
# we are making an API request with a token to an otherwise unchecked URL
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just commenting to be able to link to this more easily

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely add such a check.

my $tx = $self->SUPER::create_request($params);

my $headers = $tx->req->headers;
# TODO there might be more than one gitea server -> add sections?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just commenting to be able to link to this more easily

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to be able to configure one token per instance, so yes we probably need multiple sections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants