Emit restart events from _hook_script #6813
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue: https://progress.opensuse.org/issues/190557 Signed-off-by: Ioannis Bonatakis <[email protected]>
perlpunk
reviewed
Oct 21, 2025
|
|
||
| if ($retries && $skip_rc && defined $rc && $rc == $skip_rc && $job->retries < $retries) { | ||
| $job->app->log->debug("Job @{[$job->id]}: Retrying @{[$job->retries]} times with linear delay: ${delay}s"); | ||
| $job->app->events->emit('openqa_hook_script_job_restart', [{job_id => $openqa_job_id, minion_id => $job->id}]); |
Contributor
There was a problem hiding this comment.
That's the wrong place. There is no openQA job restart happening here. That's the hook script called from the finalize_job_results task. It runs investigation scripts for example.
In the ticket I linked to
https://github.com/os-autoinst/openQA/blob/a802d1dd235bc62d964281a687097c20b0f46cd4/lib/OpenQA/Task/Job/Restart.pm and
openQA/lib/OpenQA/Schema/Result/Jobs.pm
Line 2051 in a802d1d
Contributor
|
I assume this can be closed, see #6816 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: https://progress.opensuse.org/issues/190557