Skip to content

refactor(ruff): switch from select to ignore #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 8, 2025
Merged

refactor(ruff): switch from select to ignore #1412

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f99f004
chore(ruff): add rules
cmp0xff Oct 5, 2025
c664a0d
refactor(ruff): safe
cmp0xff Oct 5, 2025
d120bea
refactor(ruff): unsafe
cmp0xff Oct 5, 2025
1b34b99
fix: typing
cmp0xff Oct 6, 2025
85ab0f9
fix: conftest
cmp0xff Oct 7, 2025
6847e86
fix: pyrefly
cmp0xff Oct 7, 2025
06f1136
fix: pyrefly
cmp0xff Oct 7, 2025
3e7bb89
fix(comment): C417 https://github.com/pandas-dev/pandas-stubs/pull/14…
cmp0xff Oct 7, 2025
faa516e
chore(ruff): SLF001
cmp0xff Oct 7, 2025
2e81ce6
feat(ruff): S301
cmp0xff Oct 7, 2025
5cb4685
fix(ruff): TD004
cmp0xff Oct 7, 2025
83518db
chore(ruff): ERA, S
cmp0xff Oct 7, 2025
b6394f9
fix(ruff): tweak rules
cmp0xff Oct 7, 2025
ace7a24
chore: pyrefly and mypy
cmp0xff Oct 7, 2025
f251900
fix(comment): B009 https://github.com/pandas-dev/pandas-stubs/pull/14…
cmp0xff Oct 7, 2025
0a322ba
chore: ANN
cmp0xff Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(ruff): SLF001
  • Loading branch information
@cmp0xff
cmp0xff committed Oct 7, 2025
commit faa516e047154a203016bad42c4607385e212eb4
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,8 @@ ignore = [
"PLC0415", # https://docs.astral.sh/ruff/rules/import-outside-top-level/
"S101", # https://docs.astral.sh/ruff/rules/assert/
"S301", # https://docs.astral.sh/ruff/rules/suspicious-pickle-usage/
Copy link
Collaborator

@Dr-Irv Dr-Irv Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can limit this to one file tests/test_io.py

Copy link
Contributor Author

@cmp0xff cmp0xff Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

"SLF001", # https://docs.astral.sh/ruff/rules/private-member-access/
# The following rules are ignored temporarily. Either fix them or move to the permanent list above.
"SLF001", # https://docs.astral.sh/ruff/rules/private-member-access/
"ANN", "ARG", "ERA", "RUF", "SIM", "TRY", "PT", "NPY", "N", "DTZ", "PLR", "TC", "PGH", "PTH", "S311", "C901", "FIX", "TD", "A001", "PYI042", "ANN201"
Copy link
Collaborator

@Dr-Irv Dr-Irv Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • FIX and TD relates to TODO, so we can do a per-file ignore
  • Surprised that ANN201 isn't already taken care of because that's the one that requires return types on functions

Copy link
Contributor Author

@cmp0xff cmp0xff Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • FIX and TD now more detailed
  • ANN201 will be fixed in a separate PR

]

Expand Down