feat: Sharded replication pool

.eslintrc.js

@@ -28,143 +28,156 @@ module.exports = {
     'jsdoc/valid-types': 'error',
     'jsdoc/no-types': 'error',
 
-    // enable this as an error, or keep disabled (not warning)
-    'unicorn/no-unsafe-regex': 'off',
-
-    // Enable this one if you want to prevent creating throwaway objects (perf)
+    // TODO: enable in follow-up PR. Requires the utils package.
+    'no-restricted-syntax': 'off',
+    'no-restricted-imports': 'off',
+    '@typescript-eslint/ban-types': 'off',
+    // TODO: enable in follow-up PR. Requires enabling TSC's noUncheckedIndexedAccess
+    '@typescript-eslint/no-unnecessary-condition': 'off',
+    // TODO: enable in follow-up PR. Requires manual code changes.
+    '@typescript-eslint/naming-convention': 'off',
+    '@typescript-eslint/unbound-method': 'off',
+    '@typescript-eslint/member-ordering': 'off',
     'unicorn/no-object-as-default-parameter': 'off',
-
-    // Too opinionated
-    'unicorn/prefer-set-has': 'off',
+    '@typescript-eslint/prefer-optional-chain': 'off',
+    'logical-assignment-operators': 'off',
   },
-  overrides: [{
-    files: ['**/*.{js,mjs,cjs}'],
-    rules: {
-      'jsdoc/no-types': 'off',
-      'jsdoc/require-param-type': 'error',
-      'jsdoc/check-types': 'error',
-      'jsdoc/require-returns-type': 'error',
-    },
-  }, {
-    files: ['**/*.js'],
-    rules: {
-      // These rules have been disabled in .js files to ease adoption.
-      // They'll be fixed during the TS migration.
-      // Remove these once most files have been migrated to TS.
-
-      // This will catch a lot of bugs with early-returns
-      'consistent-return': 'off',
-
-      // code smells that should be resolved
-      'no-restricted-syntax': 'off',
-      'no-await-in-loop': 'off',
-      'default-case': 'off',
-      'no-loop-func': 'off',
-      'no-shadow': 'off',
-      'default-param-last': 'off',
-      'no-fallthrough': 'off',
-      'prefer-rest-params': 'off',
-      'no-loss-of-precision': 'off',
-
-      // optimisation
-      'unicorn/consistent-function-scoping': 'off',
-
-      // array.reduce is difficult to reason about and can almost always
-      // be replaced by a more explicit method
-      'unicorn/no-array-reduce': 'off',
-      'unicorn/no-array-for-each': 'off',
-      'unicorn/prefer-spread': 'off',
-
-      // makes code clearer
-      'unicorn/prefer-default-parameters': 'off',
-      'max-statements-per-line': 'off',
-
-      // makes debug easier
-      'func-names': 'off',
-
-      // multi-assigns can be difficult to understand
-      // https://eslint.org/docs/rules/no-multi-assign
-      'no-multi-assign': 'off',
-
-      // GitHub's display length is 125 chars.
-      // This enforces that length.
-      'max-len': 'off',
-      'max-depth': 'off',
-
-      // Reduce diff noise.
-      'import/order': 'off',
-
-      // consistency
-      'unicorn/filename-case': 'off',
-
-      // Passing a function reference to an array callback can accidentally introduce bug
-      // due to array methods passing more than one parameter.
-      'unicorn/no-array-callback-reference': 'off',
+  overrides: [
+    {
+      files: ['**/*.{js,mjs,cjs}'],
+      rules: {
+        'jsdoc/no-types': 'off',
+        'jsdoc/require-param-type': 'error',
+        'jsdoc/check-types': 'error',
+        'jsdoc/require-returns-type': 'error',
+      },
     },
-  }, {
-    // most tests are written in old JS style
-    // let's disable the most problematic rules for now.
-    // they're only disabled for .js files.
-    // .ts files will need to migrate.
-    files: ['packages/*/test/**/*.js'],
-    rules: {
-      'func-names': 'off',
-      'import/order': 'off',
-
-      'consistent-this': 'off',
-      'no-invalid-this': 'off',
-      'unicorn/no-this-assignment': 'off',
-      'no-unused-expressions': 'off',
-      camelcase: 'off',
-      'no-console': 'off',
-      'no-prototype-builtins': 'off',
-      'no-multi-spaces': 'off',
-      'unicorn/error-message': 'off',
+    {
+      files: ['**/*.js'],
+      rules: {
+        // These rules have been disabled in .js files to ease adoption.
+        // They'll be fixed during the TS migration.
+        // Remove these once most files have been migrated to TS.
+
+        // This will catch a lot of bugs with early-returns
+        'consistent-return': 'off',
+
+        // code smells that should be resolved
+        'no-restricted-syntax': 'off',
+        'no-await-in-loop': 'off',
+        'default-case': 'off',
+        'no-loop-func': 'off',
+        'no-shadow': 'off',
+        'default-param-last': 'off',
+        'no-fallthrough': 'off',
+        'prefer-rest-params': 'off',
+        'no-loss-of-precision': 'off',
+
+        // optimisation
+        'unicorn/consistent-function-scoping': 'off',
+
+        // array.reduce is difficult to reason about and can almost always
+        // be replaced by a more explicit method
+        'unicorn/no-array-reduce': 'off',
+        'unicorn/no-array-for-each': 'off',
+        'unicorn/prefer-spread': 'off',
+
+        // makes code clearer
+        'unicorn/prefer-default-parameters': 'off',
+        'max-statements-per-line': 'off',
+
+        // makes debug easier
+        'func-names': 'off',
+
+        // multi-assigns can be difficult to understand
+        // https://eslint.org/docs/rules/no-multi-assign
+        'no-multi-assign': 'off',
+
+        // GitHub's display length is 125 chars.
+        // This enforces that length.
+        'max-len': 'off',
+        'max-depth': 'off',
+
+        // Reduce diff noise.
+        'import/order': 'off',
+
+        // consistency
+        'unicorn/filename-case': 'off',
+
+        // Passing a function reference to an array callback can accidentally introduce bug
+        // due to array methods passing more than one parameter.
+        'unicorn/no-array-callback-reference': 'off',
+      },
     },
-  }, {
-    // Disable slow rules that are not important in tests (perf)
-    files: ['packages/*/test/**/*'],
-    rules: {
-      'import/no-extraneous-dependencies': 'off',
-      // no need to check jsdoc in tests & docs
-      'jsdoc/check-types': 'off',
-      'jsdoc/valid-types': 'off',
-      'jsdoc/tag-lines': 'off',
-      'jsdoc/check-tag-names': 'off',
-
-      // Enable test-specific rules (perf)
-      'mocha/no-exclusive-tests': 'error',
-      'mocha/no-skipped-tests': 'warn',
-
-      // it's fine if we're not very efficient in tests.
-      'no-inner-declarations': 'off',
-      'unicorn/no-unsafe-regex': 'off',
-
-      // because of Chai
-      '@typescript-eslint/no-unused-expressions': 'off',
+    {
+      // most tests are written in old JS style
+      // let's disable the most problematic rules for now.
+      // they're only disabled for .js files.
+      // .ts files will need to migrate.
+      files: ['packages/*/test/**/*.js'],
+      rules: {
+        'func-names': 'off',
+        'import/order': 'off',
+
+        'consistent-this': 'off',
+        'no-invalid-this': 'off',
+        'unicorn/no-this-assignment': 'off',
+        'no-unused-expressions': 'off',
+        camelcase: 'off',
+        'no-console': 'off',
+        'no-prototype-builtins': 'off',
+        'no-multi-spaces': 'off',
+        'unicorn/error-message': 'off',
+      },
     },
-    env: {
-      mocha: true,
+    {
+      // Disable slow rules that are not important in tests (perf)
+      files: ['packages/*/test/**/*', '*.test.{ts,js}'],
+      rules: {
+        'import/no-extraneous-dependencies': 'off',
+        // no need to check jsdoc in tests & docs
+        'jsdoc/check-types': 'off',
+        'jsdoc/valid-types': 'off',
+        'jsdoc/tag-lines': 'off',
+        'jsdoc/check-tag-names': 'off',
+
+        // Enable test-specific rules (perf)
+        'mocha/no-exclusive-tests': 'error',
+        'mocha/no-skipped-tests': 'warn',
+
+        // it's fine if we're not very efficient in tests.
+        'no-inner-declarations': 'off',
+        'unicorn/no-unsafe-regex': 'off',
+
+        // because of Chai
+        '@typescript-eslint/no-unused-expressions': 'off',
+      },
+      env: {
+        mocha: true,
+      },
     },
-  }, {
-    files: ['packages/*/test/types/**/*'],
-    rules: {
-      // This code is never executed, it's typing only, so these rules make no sense:
-      '@typescript-eslint/no-unused-vars': 'off',
-      '@typescript-eslint/no-floating-promises': 'off',
-      'no-console': 'off',
+    {
+      files: ['packages/*/test/types/**/*'],
+      rules: {
+        // This code is never executed, it's typing only, so these rules make no sense:
+        '@typescript-eslint/no-unused-vars': 'off',
+        '@typescript-eslint/no-floating-promises': 'off',
+        'no-console': 'off',
+      },
     },
-  }, {
-    files: ['**/tsconfig.json'],
-    rules: {
-      'json/*': ['error', { allowComments: true }],
+    {
+      files: ['**/tsconfig.json'],
+      rules: {
+        'json/*': ['error', { allowComments: true }],
+      },
     },
-  }, {
-    files: ['sscce.ts'],
-    rules: {
-      'no-console': 'off',
+    {
+      files: ['sscce.ts'],
+      rules: {
+        'no-console': 'off',
+      },
     },
-  }],
+  ],
   settings: {
     jsdoc: {
       tagNamePreference: {
@@ -195,7 +208,10 @@ module.exports = {
   ignorePatterns: [
     'packages/*/lib/**/*',
     'packages/*/types/**/*',
+    'packages/**/skeletons/**/*',
     '.typedoc-build',
+    'packages/cli/migrations/**/*',
+    'packages/cli/seeds/**/*',
   ],
   env: {
     node: true,

.github/CODEOWNERS

@@ -0,0 +1 @@
+* @sequelize/code-reviewers

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,9 +1,9 @@
 ---
 name: 🐛 Bug report
 about: Create a bug report to help us improve
-title: ""
-labels: ["type: bug", "pending-approval"]
-assignees: ""
+title: ''
+labels: ['type: bug', 'pending-approval']
+assignees: ''
 ---
 
 <!--
@@ -83,4 +83,4 @@ To find the version numbers for the three systems below use the following comman
 
 <!-- do not delete this footer -->
 
-*Indicate your interest in the resolution of this issue by adding the 👍 reaction. Comments such as "+1" will be removed.*
+_Indicate your interest in the resolution of this issue by adding the 👍 reaction. Comments such as "+1" will be removed._

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,9 +1,9 @@
 ---
 name: 🚀 Feature request
 about: Suggest an idea for this project
-title: ""
-labels: ["type: feature", "pending-approval"]
-assignees: ""
+title: ''
+labels: ['type: feature', 'pending-approval']
+assignees: ''
 ---
 
 <!--
@@ -51,4 +51,4 @@ For general questions, please use one of these:
 
 <!-- do not delete this footer -->
 
-*Indicate your interest in the addition of this feature by adding the 👍 reaction. Comments such as "+1" will be removed.*
+_Indicate your interest in the addition of this feature by adding the 👍 reaction. Comments such as "+1" will be removed._

.github/PULL_REQUEST_TEMPLATE.md

@@ -16,12 +16,10 @@ If unsure about something, just do as best as you're able.
 
 <!-- NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open. -->
 
-## Description Of Change
+## Description of Changes
 
 <!-- Please provide a description of the change here. -->
 
-## Todos
+## List of Breaking Changes
 
-- [ ] <!-- e.g. #1 feature: Extend the type script definition -->
-- [ ] <!-- e.g. #2 test: Does this also work with MySQL 8? -->
-- [ ] <!-- ... -->
+<!-- If you have caused any breaking changes, you should list them below. -->

.github/workflows/authors.yml

@@ -1,8 +1,8 @@
-name: "authors update"
+name: 'authors update'
 on:
   schedule:
     # Run once a week at 00:05 AM UTC on Sunday.
-    - cron: "5 0 * * 0"
+    - cron: '5 0 * * 0'
 
   workflow_dispatch:
 
@@ -12,17 +12,17 @@ permissions:
 jobs:
   authors_update:
     permissions:
-      contents: write  # for gr2m/create-or-update-pull-request-action to push local changes
-      pull-requests: write  # for gr2m/create-or-update-pull-request-action to create a PR
+      contents: write # for gr2m/create-or-update-pull-request-action to push local changes
+      pull-requests: write # for gr2m/create-or-update-pull-request-action to create a PR
     if: github.repository == 'sequelize/sequelize'
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0
+      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
         with:
-          fetch-depth: "0" # This is required to actually get all the authors
+          fetch-depth: '0' # This is required to actually get all the authors
           persist-credentials: false
-      - run: "dev/update-authors.js" # Run the AUTHORS tool
-      - uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5 # Create a PR or update the Action's existing PR
+      - run: 'dev/update-authors.js' # Run the AUTHORS tool
+      - uses: gr2m/create-or-update-pull-request-action@86ec1766034c8173518f61d2075cc2a173fb8c97 # Create a PR or update the Action's existing PR
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
@@ -31,7 +31,7 @@ jobs:
             Here are some new additions to the AUTHORS file.
             This is an automatically generated PR by the
             `authors.yml` GitHub Action, which runs `dev/update-authors.js`.
-          branch: "actions/authors-update" # Custom branch *just* for this Action.
-          commit-message: "meta: update sequelize AUTHORS"
+          branch: 'actions/authors-update' # Custom branch *just* for this Action.
+          commit-message: 'meta: update sequelize AUTHORS'
           labels: meta
-          title: "meta: update sequelize AUTHORS"
+          title: 'meta: update sequelize AUTHORS'