Alex/latest sequelize core composite key support #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
progress with target progress with add fk's normalization logic for 1-1 relationships progress make sure both foreignkey and foreignkeys are not used at the same time add foreignkey to omit add tests for composite foreign keys in belongs to kinda works? belongsTo with tests add sourcekey to helper add and comment tests to has one support for composite get¨ create indexes properly without reference change test names create composite key constraint rename to foreignKeyConstraints chore: add more tests and cleanup to branch (#5) * add composite foreign key constraints with sync * change composite fkey constraint name generation logic to be similar to other sequelize keys * change composite fkey constraint name generation logic to be similar to other sequelize keys * add more test cases * add more tests for composite key constraints creation * clean up a bit * change variable name to avoid collision in options that doesnt appear in model definition .-. * add extra teest for custom fk name * more tests and cleanup * more cleanup remove commented tests
wd-alejandroescobedogarcia
force-pushed
the
alex/latest-sequelize-core-composite-key-support
branch
from
e5b20b7 to
13b751a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tbd
Pull Request Checklist
Description Of Change
Todos