feat(ExpandableSection): Allow more control over toggle icon #12051
Conversation
|
Preview: https://pf-react-pr-12051.surge.sh A11y report: https://pf-react-pr-12051-a11y.surge.sh |
Allow for custom icons and disabled icons.
rebeccaalpert
force-pushed
the
expandable-icon
branch
from
9849dc6 to
055efb6
Compare
| /** Whether to show a toggle icon when variant is not truncated. */ | ||
| hasToggleIcon?: boolean; |
There was a problem hiding this comment.
Not 100% about allowing the icon to totally be removed since it kinda removes the indication that you can click to expand/collapse something as well as its current state. If the toggle text updates based on the state + the text indicates somehow that it expands/collapses something, then less of an issue probably.
Maybe if we just have the prop description mention that if an icon is omitted, we recommend the toggle text to indicate the current state of the expandable section. Should we also get design sign off on this?
There was a problem hiding this comment.
This is sort of what I'm thinking could be an issue:
I know this is expanded because I clicked it to expand it + knew it started as collapsed, but in other contexts it may not be clear that that is the case.
There was a problem hiding this comment.
We can add an error? My concern is that the consumer asked for a way for consumers to provide their own custom icon directly as part of the toggle content.
There was a problem hiding this comment.
I think allowing a custom icon would be fine - I assume whatever icon they pass in would retain the transition between expanded and collapsed at least. I'd be more wary about allowing the removal of the icon entirely is all.
There was a problem hiding this comment.
Got it - let me bug them and see if they can get by with the smaller change.
rebeccaalpert
requested review from
a team,
dlabaj and
kmcfaul
and removed request for
a team
3 participants
Allow for custom icons and disabled icons.
What: Closes #12029
Additional issues: