Fix for #450 #503
Merged
Fix for #450 #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuwCampbell
force-pushed
the
topic/help-on-empty-inline
branch
from
c3979ce to
7525f3d
Compare
HuwCampbell
force-pushed
the
topic/help-on-empty-inline
branch
from
7525f3d to
082498f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slightly nicer implementation, in that it doesn't force two ways of supplying this information back to the help text generator.
The idea is that we already have a way of knowing when we enter a sub command with
enterContext,with a little bit more information stored in the runner monad when we consume arguments, flags, and options, we can know if we're at the start.